Skip to content

Conversation

notriddle
Copy link
Contributor

Fixes #106413
Fixes #80636

@rustbot
Copy link
Collaborator

rustbot commented Sep 1, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 1, 2023
@rust-log-analyzer

This comment has been minimized.

@notriddle notriddle force-pushed the notriddle/issue-106413 branch from 046a5cf to 62835c9 Compare September 1, 2023 03:14
@oli-obk
Copy link
Contributor

oli-obk commented Sep 1, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 1, 2023

📌 Commit ba9af10 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#115411 (miri ABI check: fix handling of 1-ZST; don't accept sign differences)
 - rust-lang#115424 (diagnostics: avoid wrong `unused_parens` on `x as (T) < y`)
 - rust-lang#115425 (remove unnecessary heap allocation)
 - rust-lang#115446 (fix version for abi_thiscall to 1.73.0, which was forgotten to change when stabilized and (later) moved to beta)
 - rust-lang#115447 (Add comment so pub items are not removed)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 888dc2e into rust-lang:master Sep 1, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 1, 2023
@notriddle notriddle deleted the notriddle/issue-106413 branch September 1, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for unused_parens in x as (T) < y Unfortunate warning about “unnecessary parentheses” that aren’t really unnecessary
5 participants